Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(benchmark): Run 3 times a night to account for fluctuations #10791

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Sep 12, 2024

Summary

Run nightly benchmark 3 times a night to account for fluctuations. Also don't run at hour sharp, since GH might delay and drop queued runs if there's high demand, and GH recommends using something other than that.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Also don't run at hour sharp, since GH might delay and drop queued runs if
there's high demand, and GH recommends using something other than that.
Copy link

cypress bot commented Sep 12, 2024

n8n    Run #6853

Run Properties:  status check passed Passed #6853  •  git commit dd1c272465: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project n8n
Branch Review run-nightly-benchmark-3-times-a-night
Run status status check passed Passed #6853
Run duration 04m 43s
Commit git commit dd1c272465: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Committer Tomi Turtiainen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 429
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Sep 12, 2024
@tomi tomi merged commit 2be601a into master Sep 12, 2024
32 checks passed
@tomi tomi deleted the run-nightly-benchmark-3-times-a-night branch September 12, 2024 14:12
MiloradFilipovic added a commit that referenced this pull request Sep 13, 2024
* master:
  fix(editor): Fix completion on $input.item. in Code node (#10800)
  feat(OpenAI Node): Include O1 models in the models select (#10801)
  build: Disable `node-param-collection-type-unsorted-items` for langchain nodes (no-changelog) (#10802)
  fix(editor): Render the current first in CollaborationPane (no-changelog) (#10799)
  refactor(core): Enable import/order eslint rule (#10794)
  fix(benchmark): Fix benchmark license tenant (#10798)
  build: Upgrade nodelinter to 1.16.2 (no-changelog) (#10779)
  refactor(core): Migrate `Modal.vue` to composition API (no-changelog) (#10792)
  ci(benchmark): Run 3 times a night to account for fluctuations (#10791)
  refactor(editor): Convert `NodeExecuteButton` to composition api (#10703)
  refactor(benchmark): Use kebab-case for file and directory names (#10787)
@janober
Copy link
Member

janober commented Sep 18, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants